Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common_type_s #698

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix common_type_s #698

merged 1 commit into from
May 20, 2024

Conversation

anakinxc
Copy link
Collaborator

Pull Request

What problem does this PR solve?

Issue Number: Fixed #697

@anakinxc anakinxc requested a review from tpppppub May 20, 2024 06:35
tpppppub
tpppppub approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@tpppppub tpppppub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakinxc anakinxc merged commit 5f5f341 into main May 20, 2024
13 checks passed
@anakinxc anakinxc deleted the anakinxc-patch-1 branch May 20, 2024 07:18
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpppppub tpppppub tpppppub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: Common type of Ashare and Bshare
2 participants
@anakinxc @tpppppub